New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:drawer): drawer not open #8120
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #8120 +/- ##
==========================================
- Coverage 91.67% 91.66% -0.02%
==========================================
Files 518 517 -1
Lines 17786 17785 -1
Branches 2719 2719
==========================================
- Hits 16306 16303 -3
- Misses 1179 1180 +1
- Partials 301 302 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
@NgModule({ | ||
providers: [NzDrawerService] | ||
}) | ||
export class NzDrawerServiceModule {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to provide services directly on NzDrawerModule instead of NzDrawerServiceModule?
For NzDrawerServiceModule we can delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah of course i will do it then merge it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah of course i will do it then merge it ;)
@HyperLife1119 seems good now :)
Drawer don't open in a lazyload module refactor(module:drawer): remove useless DrawerServiceModule
46bfd21
to
5c1cda1
Compare
@OriginRing do you think it's possible to add also this in the next release ? I think this issue is also a block issue no ? |
When are the Releases published? |
Drawer don't open in a lazyload module
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
This pr is a fix.
What is the current behavior?
The drawer does not open if the NzDrawerModule is imported into a lazyloader module and one of the components of the lazyloader module injects a service also declared in the lazyloader module.
The fact that the NzDrawerService service was injected into the Root injector prevented the resolution of the Lazyloader service, simply because the parentInjector was not the right one.
Issue Number: #8100
What is the new behavior?
User can now use the NzDrawerService in a lazyload module
Does this PR introduce a breaking change?
Other information