Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): compatible with rxjs v6 #8133

Merged
merged 1 commit into from Oct 23, 2023

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Oct 23, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Since angular/core is still compatible with rxjs v6, we need to be compatible with it too.

https://github.com/angular/angular/blob/16.2.x/packages/core/package.json#L19

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 23, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #8133 (bdca356) into master (24d0664) will not change coverage.
The diff coverage is n/a.

❗ Current head bdca356 differs from pull request most recent head 7c008e5. Consider uploading reports for the commit 7c008e5 to get more accurate results

@@           Coverage Diff           @@
##           master    #8133   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         517      517           
  Lines       17795    17795           
  Branches     2724     2724           
=======================================
  Hits        16582    16582           
  Misses       1180     1180           
  Partials       33       33           
Files Coverage Δ
components/cascader/cascader.service.ts 100.00% <ø> (ø)

@OriginRing OriginRing merged commit 54a5c76 into NG-ZORRO:master Oct 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants