Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:flex): add flex component #8145

Merged
merged 39 commits into from Dec 4, 2023

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Added flex component. Already exist in Ant design

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Nov 2, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fde48f9) 91.69% compared to head (61a1c24) 91.70%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8145   +/-   ##
=======================================
  Coverage   91.69%   91.70%           
=======================================
  Files         519      521    +2     
  Lines       17857    17901   +44     
  Branches     2735     2749   +14     
=======================================
+ Hits        16374    16416   +42     
+ Misses       1184     1183    -1     
- Partials      299      302    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simplejason
Copy link
Member

Thanks for your contribution, I'll add the Chinese translation after the merge, or I can add it directly to your PR if that's ok with you, we plan to release this feature with v17 :)

@HyperLife1119
Copy link
Collaborator

It is worth noting that not only the component functions, but also the css class we need to be consistent with ant-design.

@ParsaArvanehPA
Copy link
Contributor Author

It is worth noting that not only the component functions, but also the css class we need to be consistent with ant-design.

Thank you for the reminder. I will ensure that both the component functions and the css class are consistent with ant-design in this component and the future components I contribute to.

@ParsaArvanehPA
Copy link
Contributor Author

Thank you for your patience. I apologize for the delay. All the mentioned changes are made. Please check them and let me know your feedback.
@HyperLife1119

@HyperLife1119
Copy link
Collaborator

We are very close to success :)
@ParsaArvanehPA

@ParsaArvanehPA
Copy link
Contributor Author

ParsaArvanehPA commented Nov 18, 2023

We are very close to success :)

:DDDD

The last changes have been made :)
Please check them and let me know if they require any change

@HyperLife1119
Copy link
Collaborator

Well done, Parsa. Now just need to wait for the CI to come through.

@ParsaArvanehPA
Copy link
Contributor Author

Well done, Parsa. Now just need to wait for the CI to come through.

Thank you very much, @HyperLifelll9. I am grateful for all the time and energy you spent on this pull request. You have been very helpful and supportive throughout the process. I hope the CI goes well and we can merge this soon :)

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParsaArvanehPA
Copy link
Contributor Author

LGTM!

@HyperLife1119
Greetings, I am inquiring about the progress of my pull request that received approval some time ago. I am eager to see my work published and integrated into the main branch. Could you please update me on the expected release date of this feature? I appreciate your prompt response and collaboration.

@HyperLife1119
Copy link
Collaborator

cc @simplejason

@HyperLife1119 HyperLife1119 merged commit f8fedfc into NG-ZORRO:master Dec 4, 2023
9 checks passed
@c01nd01r
Copy link

c01nd01r commented Jan 7, 2024

Hello, guys!
Is this component already available in the release? I see it in the 'ng-zorro-antd/flex' package, but I don't find it in the documentation on the website.

@ParsaArvanehPA
Copy link
Contributor Author

Hello, guys! Is this component already available in the release? I see it in the 'ng-zorro-antd/flex' package, but I don't find it in the documentation on the website.

Hi @c01nd01r
Ng-zorro site is still on version 17.0.1, this feature was released on version 17.1.0 (#8300).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants