New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:flex): add flex component #8145
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8145 +/- ##
=======================================
Coverage 91.69% 91.70%
=======================================
Files 519 521 +2
Lines 17857 17901 +44
Branches 2735 2749 +14
=======================================
+ Hits 16374 16416 +42
+ Misses 1184 1183 -1
- Partials 299 302 +3 ☔ View full report in Codecov by Sentry. |
Thanks for your contribution, I'll add the Chinese translation after the merge, or I can add it directly to your PR if that's ok with you, we plan to release this feature with v17 :) |
It is worth noting that not only the component functions, but also the css class we need to be consistent with ant-design. |
Thank you for the reminder. I will ensure that both the component functions and the css class are consistent with ant-design in this component and the future components I contribute to. |
Thank you for your patience. I apologize for the delay. All the mentioned changes are made. Please check them and let me know your feedback. |
We are very close to success :) |
:DDDD The last changes have been made :) |
Well done, Parsa. Now just need to wait for the CI to come through. |
Thank you very much, @HyperLifelll9. I am grateful for all the time and energy you spent on this pull request. You have been very helpful and supportive throughout the process. I hope the CI goes well and we can merge this soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@HyperLife1119 |
cc @simplejason |
Hello, guys! |
Hi @c01nd01r |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Added flex component. Already exist in Ant design
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information