Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tooltip,popover,popconfirm): make cdkConnectedOverlayPush open for tooltip #8166

Merged

Conversation

yuhengzhouz
Copy link
Contributor

@yuhengzhouz yuhengzhouz commented Nov 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6479

What is the new behavior?

cdkConnectedOverlayPush would be open for tooltip, popover and popconfirm

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Nov 17, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (198644a) 0.00% compared to head (776b6cf) 91.72%.
Report is 76 commits behind head on master.

❗ Current head 776b6cf differs from pull request most recent head fec4b79. Consider uploading reports for the commit fec4b79 to get more accurate results

Files Patch % Lines
components/qr-code/qrcode.ts 72.00% 7 Missing ⚠️
components/color-picker/color-picker.component.ts 92.59% 5 Missing and 1 partial ⚠️
components/color-picker/color-format.component.ts 89.79% 2 Missing and 3 partials ⚠️
components/core/util/dynamic-css.ts 64.28% 2 Missing and 3 partials ⚠️
components/resizable/resize-handle.component.ts 20.00% 4 Missing ⚠️
components/select/select.component.ts 72.72% 0 Missing and 3 partials ⚠️
components/form/form-label.component.ts 75.00% 2 Missing ⚠️
components/hash-code/hash-code.component.ts 90.90% 1 Missing and 1 partial ⚠️
...mponents/table/src/cell/custom-column.directive.ts 89.47% 1 Missing and 1 partial ⚠️
components/tree/tree-node.component.ts 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8166       +/-   ##
===========================================
+ Coverage        0   91.72%   +91.72%     
===========================================
  Files           0      519      +519     
  Lines           0    17847    +17847     
  Branches        0     2732     +2732     
===========================================
+ Hits            0    16371    +16371     
- Misses          0     1178     +1178     
- Partials        0      298      +298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simplejason simplejason changed the title feat(module:tooltip, *): make cdkConnectedOverlayPush open for tooltip feat(module:tooltip,popover,popconfirm): make cdkConnectedOverlayPush open for tooltip Nov 18, 2023
@simplejason simplejason merged commit a821c62 into NG-ZORRO:master Nov 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants