Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:schematics): cannot generate files and add default builders #8176

Merged
merged 1 commit into from Nov 20, 2023

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Nov 20, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  1. Due to different default builder for webpack and esbuild, there will be an error when updating zorro in the old projects using webpack
Your project is not using the default builders for "build". The NG-ZORRO schematics cannot add a theme to the workspace configuration if the builder has been changed.
  1. Failed to generate files from template when using ng generate

Issue Number: N/A

What is the new behavior?

  1. Both the @angular-devkit/build-angular/application and the @angular-devkit/build-angular/browser builders are supported.
  2. Generate files successfully.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Since angular v17, the standalone option is defaults to true, hence there is no need to set it to true explicitly.

Copy link

zorro-bot bot commented Nov 20, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e75de2b) 91.70% compared to head (5170f42) 91.70%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8176   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         519      519           
  Lines       17885    17885           
  Branches     2747     2747           
=======================================
  Hits        16402    16402           
  Misses       1181     1181           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simplejason simplejason merged commit de8a6b7 into NG-ZORRO:master Nov 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants