Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cron-expression): output type error #8189

Merged
merged 1 commit into from Dec 4, 2023

Conversation

OriginRing
Copy link
Collaborator

fix: #8188

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Copy link

zorro-bot bot commented Nov 27, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e75de2b) 91.70% compared to head (a269820) 91.71%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8189   +/-   ##
=======================================
  Coverage   91.70%   91.71%           
=======================================
  Files         519      519           
  Lines       17885    17890    +5     
  Branches     2747     2836   +89     
=======================================
+ Hits        16402    16407    +5     
  Misses       1181     1181           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54 Nicoss54 merged commit ad02381 into NG-ZORRO:master Dec 4, 2023
9 checks passed
@OriginRing OriginRing deleted the fix/cron-value-type branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-cron-expression组件不显式指定nzType而依赖默认值linux时会返回6位
3 participants