Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:list): support standalone component #8244

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

Updated List component to work as a standalone component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Dec 1, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fd0b31) 91.70% compared to head (db18036) 91.70%.
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8244   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         519      518    -1     
  Lines       17887    17887           
  Branches     2836     2837    +1     
=======================================
+ Hits        16403    16404    +1     
+ Misses       1182     1181    -1     
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParsaArvanehPA
Copy link
Contributor Author

Do I need to change something? @HyperLife1119
I'm asking because you have added PR:partially-approved flag, but I don't see any requested changes.

@HyperLife1119
Copy link
Collaborator

You don't need any changes :)

@OriginRing
Copy link
Collaborator

LGTM

@OriginRing OriginRing merged commit 1f3010f into NG-ZORRO:master Dec 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants