Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:dropdown): support standalone component #8254 #8255

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Dec 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

Updated Dropdown component to work as a standalone component.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Dec 1, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (165f171) 91.71% compared to head (cf3c60d) 91.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8255      +/-   ##
==========================================
- Coverage   91.71%   91.70%   -0.02%     
==========================================
  Files         518      518              
  Lines       17887    17887              
  Branches     2837     2837              
==========================================
- Hits        16405    16403       -2     
- Misses       1181     1182       +1     
- Partials      301      302       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ParsaArvanehPA ParsaArvanehPA changed the title Feature/dropdown component support standalone feat(module:dropdown): support standalone component #8254 Dec 1, 2023
@ParsaArvanehPA
Copy link
Contributor Author

Some of my latest PRs, have a failed codecov/project pipe.
Since you guys have skipped these said PRs, should I make any changes to make the pipe pass or you guys assumed that the failed pipe is test related and skipped it because of that?
BTW there is no hint in the review panel as to where the missing coverages are.
@HyperLife1119 @Nicoss54

@Nicoss54
Copy link
Collaborator

Nicoss54 commented Dec 2, 2023

Some of my latest PRs, have a failed codecov/project pipe. Since you guys have skipped these said PRs, should I make any changes to make the pipe pass or you guys assumed that the failed pipe is test related and skipped it because of that? BTW there is no hint in the review panel as to where the missing coverages are. @HyperLife1119 @Nicoss54

Hi Parsa Arvaneh

Thanks for all your amazing work

On my side the pipe coverage failed for the reason that the test coverage decrease of 0,01 %. This is nothing because when we will merged the pr on master the pipe coverage will success

For the moment i don’t review all your PR but try to make my possible to read as soon I can

Thanks again for your support

@ParsaArvanehPA
Copy link
Contributor Author

Some of my latest PRs, have a failed codecov/project pipe. Since you guys have skipped these said PRs, should I make any changes to make the pipe pass or you guys assumed that the failed pipe is test related and skipped it because of that? BTW there is no hint in the review panel as to where the missing coverages are. @HyperLife1119 @Nicoss54

Hi Parsa Arvaneh

Thanks for all your amazing work

On my side the pipe coverage failed for the reason that the test coverage decrease of 0,01 %. This is nothing because when we will merged the pr on master the pipe coverage will success

For the moment i don’t review all your PR but try to make my possible to read as soon I can

Thanks again for your support

Thank you for your quick response,
I appreciate your time and effort in reading my code and giving me feedback.

@HyperLife1119
Copy link
Collaborator

This is nothing. Due to the large number, we prioritized green PRs for review :)

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit c5df26f into NG-ZORRO:master Dec 4, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants