New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:dropdown): support standalone component #8254 #8255
feat(module:dropdown): support standalone component #8254 #8255
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8255 +/- ##
==========================================
- Coverage 91.71% 91.70% -0.02%
==========================================
Files 518 518
Lines 17887 17887
Branches 2837 2837
==========================================
- Hits 16405 16403 -2
- Misses 1181 1182 +1
- Partials 301 302 +1 ☔ View full report in Codecov by Sentry. |
Some of my latest PRs, have a failed |
Hi Parsa Arvaneh Thanks for all your amazing work On my side the pipe coverage failed for the reason that the test coverage decrease of 0,01 %. This is nothing because when we will merged the pr on master the pipe coverage will success For the moment i don’t review all your PR but try to make my possible to read as soon I can Thanks again for your support |
Thank you for your quick response, |
This is nothing. Due to the large number, we prioritized green PRs for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Updated Dropdown component to work as a standalone component.
Does this PR introduce a breaking change?
Other information