Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading flutter to version 1.22.0 I cannot use the plugin #34

Closed
mastahnish opened this issue Oct 15, 2020 · 3 comments
Closed

Comments

@mastahnish
Copy link

mastahnish commented Oct 15, 2020

I'm getting

Xcode's output:
↳
    /Users/jacekrys/flutter_sdk/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_exif_rotation-0.2.7/ios/Classes/SwiftFlutterExifRotationPlugin.swift:28:46: error: 'jpegData(compressionQuality:)' has been renamed to 'UIImageJPEGRepresentation(_:_:)'
                    let imageData = updatedImage.jpegData(compressionQuality: 0.8); fileManager.createFile(atPath: paths as String, contents: imageData, attributes: nil)
                                                 ^~~~~~~~
                                                 UIImageJPEGRepresentation
    UIKit.UIImage:60:17: note: 'jpegData(compressionQuality:)' was introduced in Swift 4.2
        public func jpegData(compressionQuality: CGFloat) -> Data?
                    ^
    Command CompileSwift failed with a nonzero exit code
    note: Using new build system
    note: Building targets in parallel
    note: Planning build
    note: Constructing build description
@NGhebreial
Copy link
Owner

It should work now, can you check it?

@mastahnish
Copy link
Author

mastahnish commented Oct 22, 2020

@NGhebreial now I get only this warning

    /Users/jacekrys/flutter_sdk/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_exif_rotation-0.3.1/ios/Classes/SwiftFlutterExifRotationPlugin.swift:25:21: warning: variable 'file_name' was never mutated; consider changing to 'let' constant
                    var file_name = NSURL(fileURLWithPath: imagePath).lastPathComponent!
                    ~~~ ^
                    let

@NGhebreial
Copy link
Owner

Ok I will change it but since it's just a warning I will close this, sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants