Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register version 0.4.0 #49

Closed
NHDaly opened this issue Apr 16, 2019 · 6 comments
Closed

Register version 0.4.0 #49

NHDaly opened this issue Apr 16, 2019 · 6 comments

Comments

@NHDaly
Copy link
Owner

NHDaly commented Apr 16, 2019

@JuliaRegistrator register()

@NHDaly NHDaly changed the title Trying registrator.jl again Register version 0.4.0 Apr 16, 2019
@nkottary
Copy link

The above comment is somehow ending with \r\n\r\n and Registrator is rejecting it. This is a bug in Registrator, it should trim the string.

But I'm not sure whats causing those extra characters to get input from your browser. Are you using a different OS/browser now?

@NHDaly
Copy link
Owner Author

NHDaly commented Apr 16, 2019

Yeah, huh, that's super weird! I just commented on Discourse as well:
https://discourse.julialang.org/t/switching-package-registration-systems-soon/22677/133?u=nhdaly

Huh! No, i didn't, but the first one I typed by hand, and I think all the rest I've been copy/pasting! I'm on the latest Chrome (73.0.3683.103) on the latest macOS (10.14.4 (18E226) ).

I just went back and edited the comment, and you're right that there are two blank lines at the end of the raw markdown, that of course don't register on the github.

When I copy/paste an accepted comment (from, say, here: JuliaIO/TranscodingStreams.jl#80 (comment)), it does indeed paste with the endlines:

@JuliaRegistrator register()

@NHDaly
Copy link
Owner Author

NHDaly commented Apr 16, 2019

I'll give this another shot! :)

@NHDaly
Copy link
Owner Author

NHDaly commented Apr 16, 2019

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/36

After the above pull request is merged, it is recommended that you create
a tag on this repository for the registered package version:

git tag -a v0.4.0 -m "<description of version>" 866b34418eda1a2e4f3676e4b23ece997a717d18
git push v0.4.0

@NHDaly
Copy link
Owner Author

NHDaly commented Apr 16, 2019

:) Thanks for the quick reply and for diagnosing the problem, @nkottary! :) I'm excited to be making the switch to .toml files finally!! :)

@NHDaly NHDaly closed this as completed Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants