Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.1.1.0 #114

Merged
merged 126 commits into from
Nov 14, 2017
Merged

v.1.1.0 #114

merged 126 commits into from
Nov 14, 2017

Conversation

jwallet
Copy link
Collaborator

@jwallet jwallet commented Nov 4, 2017

  • User Interface
    • Ad detector is now in Settings instead of Modules
    • DPI is now managed by the app, so it should not move anymore (except message box)
    • New game panel that hides spoilers better
      • spoilers hidden: game time and game status will always be displayed
      • spoilers displayed: scores and game status will be displayed
    • New toggle buttons in settings to control game panel
    • Stream qualities are now into a drop down list, so more details about the quality can be displayed.
    • Help button [?] now links to NHLGames wiki (support)
    • Others tweak to get ready for next version with the recorder scheduler
  • Ad Detector v2
    • still supports the same apps : Spotify and OBS
    • auto show spotify (next song enabled) and OBS to get better control of the external app when sending command NHLGames to the external app, and auto hide once done. it is a new feature, so if does not auto hide advise me @jwallet (or @w1z1k on reddit)
    • Spotify
      • now can auto skip to next song at the beginning of each ad
      • Turning on [try with the detected media player] will control any detected media player even if spotify is not detected, like window media player. note that this feature does not work with MPC since MPC is detected as an audio player.
  • Configurations
    • Enhanced hosts file code : add / remove /admin access and warning on game panels if hosts file does not work
    • Removed old hostname ChickenKiller and added PowerSports
    • New versioning, MAJOR.MINOR.BUILD.REVISION only numbers, no letters. revision should be use only in rare case (patch/hotfix). revision won't be display on UI but will be compare to next version
    • Does not save JSON files in appdata anymore, actually is not saving files at all, but it still edits your Hosts file
    • Media players and streamer custom paths now properly save
    • First launch will be slower to verify if the app has everything ready to stream properly: hostname, ip redirection configs file and internet connection
    • when starting a game if the selected stream quality is not available, a lower quality will be selected, to prevent the stream to fail.
    • Streamlink is not the default streamer anymore (livestreamer is) but the streamer path browser still accept streamlink.exe as a streamer
    • if output (recorder) is set, it will open a command window if a stream is recording (to be able to stop the streamer whenever you want)
  • External apps
    • Not using external DLL modules anymore, everything was rewritten into the main app. Ad Detector controls are now in Settings tab.
    • MPV 2.0.0 i
    • LiveStreamer is back, it's now the default streamer since StreamLink was flagged by Windows Defender. Since LiveStreamer is not updated anymore, the directory does not contains the version since version 12 is the last one.
    • Removed useless and old dependencies: Spotify-API.NET, Prims.Core, CSCore
  • Many bug fixes such as:
    • Error getting streams from remote server, the games that return 404 error how now ignored and return warning in console instead of errors
    • refreshing now also updates streams links (networks)
    • Length cannot be less than zero
    • Mpv running in process but not showing
    • not trying to resolve streams that are set to MEDIA_OFF from nhl api response
    • added a warning if the stream failed to open
    • Threads converted to tasks to avoid errors in console while asking for web requests/responses (a bit slower atm)
    • Tweaked spinners, they should not appear at the same time anymore when switching between two streams
  • Documentation
    • added informations about editing the Hosts file
    • support section: removed resolved issues
    • updated the whole documentation

Versionning: manage version in project properties under assembly infos

- mpv
- livestreamer 1.12.2
- fixed 30 warnings
- fixed 10 messages
- looking first for admin access
- asking to add entry after
- if anwser no, or did not work, it will remove any found streams and
show "NHLTV bypass failed" (quicker way to see if everything works)
- if the entry is removed, it will show the same message on game panels
- if entry is added , it will remove the warning on game panels
@jwallet jwallet added PR Ready and removed PR WIP labels Nov 11, 2017
@jwallet jwallet added PR WIP and removed PR Ready labels Nov 12, 2017
@jwallet jwallet added PR Ready and removed PR WIP labels Nov 12, 2017
@jwallet jwallet added PR WIP and removed PR Ready labels Nov 13, 2017
@jwallet jwallet added PR Ready and removed PR WIP labels Nov 13, 2017
@NHLGames NHLGames merged commit 8f7923b into MLBAMGames:master Nov 14, 2017
@jwallet jwallet deleted the refact-modules branch November 15, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants