Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAP Publishing Checks - Clarify what are credentials and secrets #18

Closed
adam-carruthers opened this issue Jul 11, 2022 · 2 comments
Closed

Comments

@adam-carruthers
Copy link

We've had some feedback that the part of the publishing checks that says "no credentials or secrets" is not clear, as analysts have not seen these terms before.

The following text might make things easier to understand:

Credentials or secrets are essentially passwords that computers use for encrypted communication or access to services. For example, with many APIs (like the Google Maps API) you must supply a credential code to access the service. Often times these codes look like long strange combinations of letters and numbers (l79sDgH9s...). We must not share our passwords publicly, so you should not commit credentials and secrets.

@SamHollings
Copy link
Collaborator

Created issue https://nhsd-jira.digital.nhs.uk/browse/NV-1328 on our backlog

@helrich
Copy link
Collaborator

helrich commented Jul 12, 2022

Suggestion implemented, issue closed.

@helrich helrich closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants