Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tagging system with autocomplete feature #77

Merged
merged 2 commits into from
Feb 1, 2017
Merged

Added Tagging system with autocomplete feature #77

merged 2 commits into from
Feb 1, 2017

Conversation

divyanshumehta
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling af2c7c4 on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@ananyo2012 ananyo2012 mentioned this pull request Jan 31, 2017
Closed
ananyo2012
ananyo2012 requested changes Jan 31, 2017
View reviewed changes
Copy link
Member

@ananyo2012 ananyo2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have requested some more changes. Solve them and the linting offenses and this is good to go

app/views/new_threads/list.html.erb Outdated
@@ -22,6 +22,10 @@
<p><%= truncate_html(new_thread.description.html_safe) %> (<%= link_to "Read more", new_thread, :class => "thread-link"%>)</p>
</div>

<div class="thread-foot">Tags :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the selectize css classes here to design the tags similar to that in the autocomplete.

app/views/new_threads/show.html.erb Outdated
@@ -26,6 +26,8 @@
</div>

<div class="thread-foot">
Tags : <%=raw @new_thread.tag_list.map {|t| link_to t,tag_path(t)}.join(', ') %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .html_safe at the end of this statement. Like .join(', ').html_safe

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling 1918f17 on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling aead020 on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@ananyo2012
Copy link
Member

@divyanshumehta solve the XSS issue as I have mentioned using .html_safe and this is good to go.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling 76fb2e8 on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling d41b3dd on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling 686fb48 on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 77.752% when pulling 38f8e83 on divyanshumehta:exp2 into 4df6d22 on NIT-dgp:github_master.

@ananyo2012
Copy link
Member

@divyanshumehta This looks good now. Merging it. Learn to write tests now.

@ananyo2012 ananyo2012 merged commit 4af5da0 into NITDgpOS:github_master Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananyo2012 ananyo2012 ananyo2012 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@divyanshumehta @coveralls @ananyo2012