Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentIdentifier.matches() is case-sensitive #95

Open
r-wrobel opened this issue Apr 29, 2024 · 0 comments
Open

DocumentIdentifier.matches() is case-sensitive #95

r-wrobel opened this issue Apr 29, 2024 · 0 comments

Comments

@r-wrobel
Copy link

Hi,
after a docs_a | docs_b union i got two matching docs. I assume the reason is the case-sensitive comparison in types.py DocumentIdentifier.matches() on case-insensitive DOI.

I suggest to sanitize the DOI with .lower() before it is appended to the Document. If it is only sanitized for comparison, the performance of the networks will decrease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant