Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated README contains badges for cffconvert #57

Closed
LourensVeen opened this issue Mar 22, 2020 · 2 comments · Fixed by #61
Closed

Generated README contains badges for cffconvert #57

LourensVeen opened this issue Mar 22, 2020 · 2 comments · Fixed by #61

Comments

@LourensVeen
Copy link
Member

For most of the badges, putting in the user's slug is going to be correct or at least a much better approximation of the correct value than having cff-converter-python in there. That's exactly why we're using cookiecutter!
@sverhoeven
Copy link
Member

PR #61 tries to resolve this issue.

This was referenced May 11, 2020
Closed
Merged
@LourensVeen
Copy link
Member Author

I guess this can be closed now? I don't have time to test right now...

@jspaaks jspaaks mentioned this issue Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace hardcoded urls in badge table with template variables NLeSC/python-template
2 participants
@sverhoeven @LourensVeen