Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimise-any: prefer popular and not large RRset #22

Merged
merged 1 commit into from Feb 4, 2020
Merged

minimise-any: prefer popular and not large RRset #22

merged 1 commit into from Feb 4, 2020

Conversation

hdais
Copy link
Contributor

@hdais hdais commented Jun 29, 2019

NSD4's RFC8482 (minimizing response for ANY query) just picks one rrset element in linked list with no preference. This can pick a large rrset (e.g. DNSKEY, RRSIG) for response, but this is not suitable for RFC8482 purpose. For example dig @h.root-servers.net . ANY often gets all RRSIGs of ".". (H-root adopts NSD4).

This patch introduces simple preference between rtypes on selecting a rrset. It prefers popular and not large rtypes (A, AAAA,..), and lowers large rtypes (DNSKEY, RRSIG,..).

Preferece order is:

  1. "Preferred" rtypes (A, AAAA, MX, SOA, PTR)
  2. "Normal" rtypes (other than 1 and 3)
  3. "Lowered" rtypes (DNSKEY, RRSIG, NSEC)

@hdais hdais requested review from wcawijngaards and removed request for wcawijngaards February 3, 2020 17:29
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, for the purpose of making smaller answers.

@wcawijngaards wcawijngaards merged commit ee593f2 into NLnetLabs:master Feb 4, 2020
@wcawijngaards
Copy link
Member

Thanks for the patch! This looks like it would make even smaller replies for type ANY. I have merged it in the code.

@hdais hdais changed the title minimise-any: prefer polular and not large RRset minimise-any: prefer popular and not large RRset Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants