improve the logging of ixfr fallbacks to axfr #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Oct 31, 2023
wcawijngaards
added a commit
that referenced
this pull request
Oct 31, 2023
- Merge #301: improve the logging of ixfr fallbacks to axfr.
|
Thank you for the code patch! The changes have been merged into the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
When nsd is used as a primary (like serving the zone after verification) it does not properly log if the zone transfer was ixfr or axfr.
It only logs what the client asked for. This is misleading because someone could think it was an ixfr reply, but with default configuration it falls back to axfr unless ixfr-out is explicitly configured.
This meant to fix that by properly logging when it falls back.
Regards,
Tamás