Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test package fixes #302

Merged
merged 6 commits into from Nov 27, 2023
Merged

Test package fixes #302

merged 6 commits into from Nov 27, 2023

Conversation

wtoorop
Copy link
Member

@wtoorop wtoorop commented Nov 16, 2023

No description provided.

@wtoorop wtoorop changed the title Some fixed to the test packages Test package fixes Nov 16, 2023
@k0ekk0ek
Copy link
Contributor

Maybe make this:

if test ! -f nsd.pid ; then
        exit 0
fi
if test -z `cat nsd.pid` ; then

A function in common.sh? Something like kill_from_pidfile?

@wtoorop
Copy link
Member Author

wtoorop commented Nov 27, 2023

@k0ekk0ek @wcawijngaards these are some non-intrusive fixes of the .tdir tests
Let me know if I can merge this...

k0ekk0ek
k0ekk0ek approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@k0ekk0ek k0ekk0ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👍

wcawijngaards
wcawijngaards approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely fixes, they all look good to have. The xfr_update fixes in particular as well the the new common.sh function that eases the test scripts.

@wtoorop
Copy link
Member Author

wtoorop commented Nov 27, 2023

Thanks @k0ekk0ek and @wcawijngaards ! Then I merge.

@wtoorop wtoorop merged commit 428880e into master Nov 27, 2023
4 checks passed
wcawijngaards added a commit that referenced this pull request Nov 27, 2023
@wcawijngaards
Changelog note for #302
bad37df 
- Merge #302: Test package fixes. Correct Auxfiles, kill_from_pidfile
  function and fix drop_updates, rr-test and xfr_update tests.
@wtoorop wtoorop deleted the maintenance/tdir-fixes branch January 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0ekk0ek k0ekk0ek k0ekk0ek approved these changes

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wtoorop @k0ekk0ek @wcawijngaards