Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "multi-master-check" in favour of "multi-primary-check" #308

Closed
anandb-ripencc opened this issue Dec 7, 2023 · 1 comment
Closed

Deprecate "multi-master-check" in favour of "multi-primary-check" #308

anandb-ripencc opened this issue Dec 7, 2023 · 1 comment

Comments

@anandb-ripencc
Copy link
Contributor

The config option multi-master-check contains the word master, which should be avoided, as per RFC 8499.

It would be nice if this option were called multi-primary-check. The previous option name could be retained as an alias for backwards compatibility.
@wcawijngaards
Copy link
Member

The commit fixes that and also the text in nsd.conf man page and example config, and also the output for nsd-checkconf and allows the older syntax to be used interchangeably. The functionality of the option is otherwise unchanged. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wcawijngaards @anandb-ripencc