Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus metric names, types and units could be cleaner and more consistent #61

Open
ximon18 opened this issue Nov 14, 2023 · 0 comments
Open

Prometheus metric names, types and units could be cleaner and more consistent #61

ximon18 opened this issue Nov 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ximon18
Copy link
Member

ximon18 commented Nov 14, 2023

Just some observations, there are probably more:

  • rotonda_task_total_poll_count_total - contains the term total twice and also count.
  • rotonda_rib_merge_update_announce_duration_microseconds_count - why does this count not end in _total (the metric type) while the one above does, do they have a different rotonda/rtrtr MetricUnit ?
@ximon18 ximon18 added the enhancement New feature or request label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ximon18