Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reloading of config and restart validation in server mode on Unix. #200

Open
partim opened this issue Aug 17, 2019 · 4 comments
Open
Milestone

Comments

@partim
Copy link
Member

partim commented Aug 17, 2019

Reloading the config should happen via SIGHUP, restarting validation should happen through SIGUSR1.

@hellerve
Copy link
Contributor

Do you have a preferred library in mind here?

@partim
Copy link
Member Author

partim commented Nov 12, 2019

Not really.

Config reload will require some rewiring. Probably best to just shut everything down, reload the config, and start up again.

@hellerve
Copy link
Contributor

Yeah I’ve been playing around with a bunch of libraries (most notably rust-simple-signal and Tokio’s mostly undocumented Unix signal handling), and there is some lifetime trickery involved that makes it a little harder than just calling repo.reload_tals() (as an example) in a handler function!

@partim
Copy link
Member Author

partim commented Nov 12, 2019

I think the best way is to use the pipe approach and ‘select’ for that instead of the current idle.wait() in Server::run.

@partim partim added this to the 0.12.0 milestone Jul 20, 2022
@partim partim modified the milestones: 0.12.0, 0.13.0 Oct 11, 2022
@partim partim modified the milestones: 0.13.0, 0.14.0 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants