In tcp_callback_writer(), don't disable time-out when changing to read. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Dec 2, 2019
|
Thanks for the fix! That is some serious deep code inspection, and what looks like a good bugfix to me. I'll merge it in a bit and make a Changelog entry for it. |
wcawijngaards
added a commit
that referenced
this pull request
Dec 2, 2019
- Merge pull request #122 from he32: In tcp_callback_writer(), don't disable time-out when changing to read.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 3, 2019
NLnetLabs/unbound#122 which fixes NLnetLabs/unbound#125 Briefly: TCP socket timeouts would effectively be disabled after the exchange of the initial DNS query/response. Bump PKGREVISION.
netbsd-srcmastr
pushed a commit
to NetBSD/src
that referenced
this pull request
Dec 3, 2019
NLnetLabs/unbound#122 This should enable proper functioning of tcp-idle-timeout.
ryo
pushed a commit
to IIJ-NetBSD/netbsd-src
that referenced
this pull request
Dec 3, 2019
NLnetLabs/unbound#122 This should enable proper functioning of tcp-idle-timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this is the cause of the apparent non-working of the tcp-idle-timeout setting,
as observed in e.g.
https://nlnetlabs.nl/pipermail/unbound-users/2019-August/011748.html