Use passed in neg and key cache if non-NULL. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this the neg and key caches can be shared between multiple libunbound contexts. The msg and rrset caches already allowed this since context_finalize() did not touch those if they are already available and have the correct size. Care must be taken to properly unhook the caches from the validator environment before calling ub_ctx_delete() otherwise one risks double free or use after free bugs.
wcawijngaards
approved these changes
Jan 6, 2020
|
So I'm fine with it, if it helps unwind. Probably not something I could easily describe for how libunbound users could make use of it. Thank you for the contribution! Best regards, Wouter |
wcawijngaards
added a commit
that referenced
this pull request
Jan 6, 2020
- Merge #135 from Florian Obser: Use passed in neg and key cache if non-NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this the neg and key caches can be shared between multiple
libunbound contexts.
The msg and rrset caches already allowed this since context_finalize()
did not touch those if they are already available and have the correct
size.
Care must be taken to properly unhook the caches from the validator
environment before calling ub_ctx_delete() otherwise one risks double
free or use after free bugs.