Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential memory leak on config failure #319

Closed
magenbluten opened this issue Oct 8, 2020 · 1 comment
Closed

potential memory leak on config failure #319

magenbluten opened this issue Oct 8, 2020 · 1 comment

Comments

@magenbluten
Copy link
Contributor

the region created here:

unbound/services/rpz.c

Line 388 in 52b0480

r->region = regional_create_custom(sizeof(struct regional));

does not get free'd in the err handling path:

unbound/services/rpz.c

Line 435 in 52b0480

err:

assuming the region could be created but one of the following actions fails.
@wcawijngaards
Copy link
Member

Thanks for the review! That is a good fix, committed in a87f05b for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magenbluten @wcawijngaards