Support for selective enabling tcp-upstream for stub/forward zones #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort only for specified stub/forward zones
wcawijngaards
approved these changes
Aug 12, 2021
wcawijngaards
added a commit
that referenced
this pull request
Aug 12, 2021
|
Thank you for the neat feature. I hope it can be useful. I have merged it and made some fixup commits. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Aug 12, 2021
* nlnet/master: (37 commits) - Fix to print error from unbound-anchor for writing to the key file, also when not verbose. - For NLnetLabs#519: fix comments for doxygen. - For NLnetLabs#519: yacc and lex. And fix python bindings, and test program unbound-dnstap-socket. Changelog note for NLnetLabs#519 and example.conf edit - Merge NLnetLabs#519: Support for selective enabling tcp-upstream for stub/forward zones. - For NLnetLabs#519: note stub-tcp-upstream and forward-tcp-upstream in the example configuration file. Changelog note for NLnetLabs#523 - Merge NLnetLabs#523: fix: free() call more than once with the same pointer. Changelog note for NLnetLabs#521 - Merge NLnetLabs#521: Update mini_event.c. - Add test tool readzone to .gitignore. - And 1.13.2rc1 became the 1.13.2 with the fix for the python module build. The current code repository continues with version 1.13.3. fix: free() call more than once with the same pointer Update mini_event.c - Fix NLnetLabs#520: Unbound 1.13.2rc1 fails to build python module. Add (stub|forward)-tcp-upstream options which enable using tcp transport only for specified stub/forward zones For 1.13.2rc1. - Tag for 1.13.2 release. - Fix unit test zonemd_reload for use in run_vm. - Fix libnettle zonemd unit test. - Fix out of sourcedir run of zonemd unit tests. - Fix readzone compile under debug config. - Fix missing locks in zonemd unit test. - Fix static analysis warnings about localzone locks that are unused. ...
|
Thanks for your time, it's great news. I also hope that this change will be useful for others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've prepared changes that allow enable tcp-upstream selectively (per stub/forward zone). Changes are inspired by PR-95. In original PR-95 there was support only for stubs - I've added also support for forward zones and prepared some test cases and docs update.
I didn't commit changes which are generated via flex/bison (util/configlexer.c, util/configparser.c) - please let me know if I should also commit these files.