Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce infra-cache-max-rtt option to config max retransmit timeout #718

Merged

Conversation

hunts
Copy link
Contributor

@hunts hunts commented Jul 16, 2022

Added the option and let it default to 120 seconds so that it won't change current behavior.

Related-to #717

Added the option and let it default to 120 seconds so that it won't change
current behavior.

Related-to NLnetLabs#717
@hunts hunts force-pushed the make_rtt_max_timeout_configurable branch from f8ef279 to 249efd4 Compare July 16, 2022 08:46
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. The default is what used to happen, so it does not change things for existing users.

@wcawijngaards wcawijngaards reopened this Jul 19, 2022
@wcawijngaards wcawijngaards linked an issue Jul 19, 2022 that may be closed by this pull request
@wcawijngaards wcawijngaards merged commit ef9bb02 into NLnetLabs:master Jul 19, 2022
wcawijngaards added a commit that referenced this pull request Jul 19, 2022
- Merge #718: Introduce infra-cache-max-rtt option to config max
  retransmit timeout.
@hunts hunts deleted the make_rtt_max_timeout_configurable branch July 19, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Make RTT_MAX_TIMEOUT configurable
2 participants