Add SVCB dohpath support #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Aug 19, 2022
gthess
requested changes
Aug 23, 2022
There was a problem hiding this comment.
I believe you miss the MUST in section 5.1
If the "alpn" SvcParam indicates support for HTTP, "dohpath" MUST be present.
I would also like to see failure-cases testing, like the above and ?dns missing from the dohpath.
Also more happy testing for printing non-printable characters?
wtoorop
requested changes
Aug 29, 2022
added 2 commits
October 28, 2022 11:14
This was referenced Dec 6, 2022
gthess
approved these changes
Jul 3, 2023
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jul 15, 2023
* nlnet/master: (43 commits) - More clear description of the different auth-zone behaviors on the man page. - Merge NLnetLabs#880 from chipitsine: services/authzone.c: remove redundant check. - Merge NLnetLabs#664 from tilan7763: Add prefetch support for subnet cache entries. - For NLnetLabs#664: Easier code flow for subnetcache prefetching. - For NLnetLabs#664: Add testcase. - For NLnetLabs#664: Rename subnet_prefetch tests to subnet_global_prefetch to differentiate from the new subnet prefetch support. - For NLnetLabs#664: easier code flow for subnetcache prefetching. - For NLnetLabs#664: add testcase. - Skip the 00-lint test. splint is not maintained; it either does not work or produces false positives. Static analysis is handled in the clang test. - For NLnetLabs#802: Cleanup comments and add RCODE check for CD bit test case. - Fix dereference of NULL variable warning in mesh_do_callback. - Code cleanup for sldns_str2wire_svcparam_key_lookup. - Fix NLnetLabs#906: warning: ‘Py_SetProgramName’ is deprecated. - For NLnetLabs#739: minor cleanup for testcases. - More fixes for reference counting for python module and clean up failure code. - Fix python modules with multiple scripts, by incrementing reference counts. - Remove warning about unknown cast-function-type warning pragma. Add changelog and contrib/README mention for NLnetLabs#903 - Merge NLnetLabs#903: contrib: add yocto compatible init script. contrib: add yocto compatible init script Changelog for NLnetLabs#887 and NLnetLabs#516 - Properly handle all return values of worker_check_request during early EDE code. - Do not check the incoming request more than once. - Fix for uncertain unit test for doh buffer size events. Changelog note for NLnetLabs#895 - Fix NLnetLabs#895: python + sysconfig gives ANOTHER path comparing to distutils. - Merge NLnetLabs#896: Fix: NLnetLabs#895: pythonmodule: add all site-packages directories to sys.path. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.