config: improve handling of unknown modules #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change fixes module print when specified module is unknown. On
example config:
server:
module-config: "respip valdator iterator"
Before the change printed error looked like:
error: Unknown value in module-config, module: ''. This module is
not present (not compiled in), See the list of linked modules with
unbound -V
After the change module is printed as expected:
error: Unknown value in module-config, module: 'valdator'. This
module is not present (not compiled in), See the list of linked
modules with unbound -V
Module truncation happens because parse error does not guarantee that
leading whitespace is removed by `module_factory()` call.
The change always removes leading whitespace (if present).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change fixes module print when specified module is unknown. On example config:
Before the change printed error looked like:
After the change module is printed as expected:
Module truncation happens because parse error does not guarantee that leading whitespace is removed by
module_factory()call.The change always removes leading whitespace (if present).