Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the origin (DNAME) TTL for synthesized CNAMEs as per RFC 6672 #973

Merged
merged 1 commit into from Dec 8, 2023
Merged

Use the origin (DNAME) TTL for synthesized CNAMEs as per RFC 6672 #973

merged 1 commit into from Dec 8, 2023
+72 −728

Conversation

gthess
Copy link
Member

@gthess gthess commented Dec 6, 2023

No description provided.

wcawijngaards
wcawijngaards approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and makes the CNAME TTL for synthesized CNAMEs that come after a DNAME record equal to the DNAME TTL, so not 0. That improves caching so that could be useful, in the few cases where DNAMEs are used in practice.

@gthess gthess changed the title Use the origin (DNAME) TTL for syntesized CNAMEs as per RFC 6672 Use the origin (DNAME) TTL for synthesized CNAMEs as per RFC 6672 Dec 8, 2023
@gthess gthess merged commit be6fd80 into master Dec 8, 2023
1 check passed
@gthess
Copy link
Member Author

gthess commented Dec 8, 2023

Thanks @wcawijngaards!

@gthess gthess deleted the synth-cname-ttl branch March 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gthess @wcawijngaards