Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .NET Standard 2.0 #2152

Closed
304NotModified opened this issue Jun 3, 2017 · 4 comments
Closed

Support .NET Standard 2.0 #2152

304NotModified opened this issue Jun 3, 2017 · 4 comments
Labels
enhancement Improvement on existing feature
Milestone
5.0 - OLD

Comments

@304NotModified
Copy link
Member

304NotModified commented Jun 3, 2017 •
edited
Loading

Results of analysis on NLog 4.4.10

details:

image
@304NotModified 304NotModified added this to the 5.0 milestone Jun 3, 2017
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Jun 3, 2017
@304NotModified
Copy link
Member Author

Zip of html (same results)

ApiPortAnalysis-NLog-netstandard2.html.zip

@304NotModified
Copy link
Member Author

http://www.michael-whelan.net/replacing-appdomain-in-dotnet-core/

@304NotModified 304NotModified mentioned this issue Jun 5, 2017
Merged
@snakefoot
Copy link
Contributor

snakefoot commented Jun 5, 2017 •
edited by 304NotModified
Loading

Should include the following changes from CoreClr-branch:

  • BaseFileAppender.cs:

if (this.CreateFileParameters.EnableFileDelete && PlatformDetector.CurrentOS != RuntimeOS.Windows )
{
fileShare |= FileShare.Delete;
}

  • ObjectGraphScanner.cs (Everything - Support NET Native)
  • ThreadLocalStorageHelper.cs (Everything)
  • StackTraceLayoutRenderer.cs (Null-check in Append)
if (logEvent.StackTrace == null)
   return;
  • AsyncHelpers.cs (WaitForDispose)
  • ConsoleTarget.cs (WriteToOutput should also catch ArgumentOutOfRangeException)
  • OutputDebugStringTarget.cs (Everything)
  • MappedDiagnosticsLogicalContext.cs (Everything)
  • InternalLoggerTests.cs (Everything- Fixes xUnit2)
  • ConfigApiTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • XmlConfigTests.cs (Everything- Fixes xUnit2)
  • GlobalDiagnosticsContextTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • MappedDiagnosticsContextTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • MappedDiagnosticsLogicalContextTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • NestedDiagnosticsContextTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • LayoutHelpersTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • MdlcLayoutRendererTests.cs (Inherit from NLogTestBase - Fixes xUnit2)
  • LogManagerTests.cs (ThreadSafe_getCurrentClassLogger_test - And remove Unity-dependency)

@304NotModified
Copy link
Member Author

Sounds good!

@304NotModified 304NotModified mentioned this issue Jun 5, 2017
Closed
6 tasks
@luigiberrettini luigiberrettini mentioned this issue Aug 21, 2017
Closed
@stil stil mentioned this issue Sep 5, 2017
Closed
@snakefoot snakefoot mentioned this issue Sep 5, 2017
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
5.0 - OLD
Development

No branches or pull requests
2 participants
@304NotModified @snakefoot