Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge UWP into NLog 4.5 - drop NLog 5 #2440

Closed
304NotModified opened this issue Dec 2, 2017 · 8 comments
Closed

Merge UWP into NLog 4.5 - drop NLog 5 #2440

304NotModified opened this issue Dec 2, 2017 · 8 comments
Milestone

Comments

@304NotModified
Copy link
Member

I think this is double.

Merge UWP target (UWP branch) to NLog 4.5

Then we could drop NLog 5 for now, as NLog 4.5 supports .NET Standard 1.5 (NLog 5 - .NET standard 1.3)

With loosing .NET Standard 1.3+1.4, we won't loose any platforms?

See https://blogs.msdn.microsoft.com/dotnet/2016/09/26/introducing-net-standard/

image

@304NotModified
Copy link
Member Author

fixed by #2441

@mfeingol
Copy link

Hi.

With loosing .NET Standard 1.3+1.4, we won't loose any platforms?

By losing .NET Standard 1.4, you've lost anyone using NLog in a .NET Standard assembly used by any UWP app targeting the Creator's Update and below. As that's my case, I'll be sticking to your 5.x pre-release versions until you can hopefully fix that.

Thanks!

@304NotModified
Copy link
Member Author

@mfeingol time to test a new rc with .net standard 1.3 support?

@mfeingol
Copy link

mfeingol commented Mar 6, 2018

Absolutely!

@304NotModified
Copy link
Member Author

cool! Will release within a few days!

@304NotModified
Copy link
Member Author

@mfeingol rc7 is in the build/release queue. Will be published in a few hours

Would be great if you could confirm soon that this will fix your case :)

@mfeingol
Copy link

mfeingol commented Mar 8, 2018

@304NotModified: it seems to be working quite well. Thanks very much!

@304NotModified
Copy link
Member Author

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants