Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constructor protection level to internal for MessageTemplateParameters and MessageTemplateParameter #2552

Closed
304NotModified opened this issue Jan 28, 2018 · 2 comments
Closed

constructor protection level to internal for MessageTemplateParameters and MessageTemplateParameter #2552

304NotModified opened this issue Jan 28, 2018 · 2 comments
Labels
enhancement Improvement on existing feature
Milestone
4.5

Comments

@304NotModified
Copy link
Member

constructor protection level to internal for

  • MessageTemplateParameters
  • MessageTemplateParameter

see #2544
@304NotModified 304NotModified added this to the 4.5 rc5 milestone Jan 28, 2018
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Jan 28, 2018
@B3nCr
Copy link

B3nCr commented Feb 9, 2018

Is there anything more to this or could a new contributor just fork and make these changes?

@snakefoot
Copy link
Contributor

@B3nCr This is partially resolved by #2544 (Fixes MessageTemplateParameters) . Not sure how important it is to hide the constructors on MessageTemplateParameter

@304NotModified 304NotModified modified the milestones: 4.5 rc5, 4.5 Feb 12, 2018
@304NotModified 304NotModified mentioned this issue Feb 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
3 participants
@B3nCr @304NotModified @snakefoot