Feature: list contextProperties of Logger

[304NotModified]

Make _contextProperties public on the Logger object.

Discussion: read-only or mutable?

asked here: https://stackoverflow.com/questions/56278360/nlog-list-property-values

[snakefoot]

Discussion: read-only or mutable?

I vote for readonly using IReadOnlyDictionary (Only have the property on platforms where interface is supported).

[304NotModified]

I checked the code. I think IDictionary is flexible enough. If we need to know changes in the dictionary, we could implement this.

[snakefoot]

Doesn't make sense. You can modify using the IDictionary-interface. It is way too flexible. You will get Collection was modified-exceptions.

Yes I know the Logger-object is very nice, and not touching the internal Dictionary. But you need to protect NLog from its evil users (Just like with the LoggingRules-collection that has been a generator of exceptions for a long time, and still is).

[304NotModified]

Do we need also a clone then? (I think so)

[snakefoot]

Do we need also a clone then? (I think so)

Would be very confusing to get a mutable dictionary returned, and your changes doesn't have any effect.

I continue to vote for IReadOnlyDictionary

[304NotModified]

That's clear ;)

But besides IReadOnlyDictionary we need a clone then. Otherwise your could cast it back. Unfortunately, you could always change and object living in the dictionary

[snakefoot]

Trying to protect yourself from a developer is hard work, and seldom gives any bonus.

Developer can also do reflection and access the dictionary that way.

The goal is to provide an easy to understand interface.

[304NotModified]

fixed by #3430