Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed EmptyDefaultDictionary from MappedDiagnosticsContext #4115

Merged
merged 1 commit into from Sep 19, 2020
Merged

Removed EmptyDefaultDictionary from MappedDiagnosticsContext #4115

merged 1 commit into from Sep 19, 2020

Conversation

snakefoot
Copy link
Contributor

No description provided.

@snakefoot snakefoot added the enhancement Improvement on existing feature label Sep 13, 2020
@snakefoot snakefoot added this to the 4.7.5 milestone Sep 13, 2020
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@304NotModified
Copy link
Member

hi! Thanks, but why do we need this?

@snakefoot
Copy link
Contributor Author

hi! Thanks, but why do we need this?

Faster performance by not doing lookup in empty-dictionary, and one less static-variable.

@snakefoot snakefoot added performance and removed enhancement Improvement on existing feature labels Sep 16, 2020
@304NotModified 304NotModified merged commit abf8d9e into NLog:master Sep 19, 2020
@304NotModified
Copy link
Member

Thanks! Merged!

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@snakefoot snakefoot deleted the MappedDiagnosticsContextEmpty branch July 30, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance size/M
Projects
None yet
Milestone
4.7.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snakefoot @304NotModified