Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonLayout - Added ExcludeEmptyProperties to skip GDC/MDC/MLDC properties with null or empty values #4221

Merged
merged 2 commits into from Jan 4, 2021
Merged

JsonLayout - Added ExcludeEmptyProperties to skip GDC/MDC/MLDC properties with null or empty values #4221

merged 2 commits into from Jan 4, 2021

Conversation

pruiz
Copy link
Contributor

@pruiz pruiz commented Dec 29, 2020

This is a clone of #4196, but targeting master instead of dev branch.

@snakefoot snakefoot added this to the 4.7.7 milestone Dec 30, 2020
snakefoot
snakefoot approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot added enhancement Improvement on existing feature json / json-layout feature needs documentation on wiki and removed enhancement Improvement on existing feature labels Jan 4, 2021
@snakefoot snakefoot merged commit 4265a63 into NLog:master Jan 4, 2021
@welcome
Copy link

welcome bot commented Jan 4, 2021

Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks!
thanks!

@snakefoot snakefoot changed the title Added a new ExcludeEmptyProperties to JsonLayout as to avoid GDC/MDC/MLDC properties with null or empty values from output (this time, against master) JsonLayout - Added new ExcludeEmptyProperties to skip GDC/MDC/MLDC properties with null or empty values Jan 20, 2021
@snakefoot snakefoot changed the title JsonLayout - Added new ExcludeEmptyProperties to skip GDC/MDC/MLDC properties with null or empty values JsonLayout - Added ExcludeEmptyProperties to skip GDC/MDC/MLDC properties with null or empty values Jan 20, 2021
@snakefoot
Copy link
Contributor

https://www.nuget.org/packages/NLog/4.7.7 has been released

@snakefoot
Copy link
Contributor

Updated wiki: https://github.com/NLog/NLog/wiki/JsonLayout

@snakefoot snakefoot added documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) and removed needs documentation on wiki labels Feb 15, 2021
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@snakefoot snakefoot mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot snakefoot approved these changes

Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) feature json / json-layout size/L
Projects
None yet
Milestone
4.7.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pruiz @snakefoot