Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TrimDirectorySeparators to handle root-path on Windows and Linux #4316

Merged
merged 1 commit into from Feb 24, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 24, 2021

Fix loading Nlog.config when application is running at root-path (Ex. D:\). Resolves #4314

Bug introduced with #2846 in NLog 4.5.9

@snakefoot snakefoot added the bug Bug report / Bug fix label Feb 24, 2021
@snakefoot snakefoot added this to the 4.7.8 milestone Feb 24, 2021
@snakefoot snakefoot changed the title Fix TrimDirectorySeparators to handle root-path on Windows and Linux … Fix TrimDirectorySeparators to handle root-path on Windows and Linux Feb 24, 2021
@304NotModified
Copy link
Member

304NotModified commented Feb 24, 2021

@snakefoot the stability of azure devops should be improved now. I've setup a restart of failed tests, and that worked, but not really as it failed on the minimum amount of tests...(meh)

LOL nice bug in Azure devops:

Total tests: 3045. Passed: 3035. Failed: 1. Skipped: 9.
##[error]Test Run Failed.
....
Failed tests: 1; Total tests: 3023;
Total failed tests as returned by TCM: 1.
Found 1 filtered test case sources.
**************** Rerunning failed tests for Test run 3674 *********************
Max attempts: 5; Current attempt: 1; Failed test cases threshold: 30; Failed test cases max limit: 0
....
Starting test execution, please wait...
....
Total tests: 1. Passed: 1. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 34.0482 Seconds
Vstest.console.exe exited with code 0.
**************** Completed test execution *********************
...
##[error]The specified minimum number of tests 100 were not executed in the test run.

full result

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants