Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogReceiverWebServiceTarget backwards compatible problem #783

Closed
tryhp3 opened this issue Jul 1, 2015 · 4 comments
Closed

LogReceiverWebServiceTarget backwards compatible problem #783

tryhp3 opened this issue Jul 1, 2015 · 4 comments
Labels
bug Bug report / Bug fix must have
Milestone

Comments

@tryhp3
Copy link

tryhp3 commented Jul 1, 2015

After the update (to NLog 4.0) I have a serious problem:

  1. 'NLog.CustomExtendedService.LogReceiverSecureService.CreateWcfLogReceiverClient()': return type must be 'NLog.LogReceiverService.WcfLogReceiverClientFacade' to match overridden member 'NLog.Targets.LogReceiverWebServiceTarget.CreateWcfLogReceiverClient()'
  2. New class WcfLogReceiverClientFacade does not include: ClientCredentials and Endpoint.
    przechwytywanie
@304NotModified
Copy link
Member

Hi,

  • I don't fully understand the problem of point 1. Yes it is a breaking change, but what is the serious problem?
  • There is an endpoint address in the LogReceiverWebServiceTarget. Could that help?

@304NotModified
Copy link
Member

PS: I noticed that WcfLogReceiverClientFacade is a mess and should be refactored. See #784

@304NotModified
Copy link
Member

I see the problem:

  • WcfLogReceiverClientFacade won't inherit from ClientBase<...>. But in 3.2.0 WcfLogReceiverClient was returned, and this class did implement ClientBase<...> (which contains 'EndpointandClientCredentailsproperties). Thus: WcfLogReceiverClientFacade should inherit fromClientBase<..>`. But this is difficult to fix. We have to find a good solution for this.

This is unwanted breaking change from #565 (it was claimed to be backwards-compatible)

@304NotModified 304NotModified added the bug Bug report / Bug fix label Jul 1, 2015
@304NotModified 304NotModified added this to the 4.1 milestone Jul 1, 2015
@304NotModified 304NotModified changed the title NLog 4.0 and custom LogReceiverWebServiceTarget problem LogReceiverWebServiceTarget backwards compatible problem Jul 17, 2015
@304NotModified
Copy link
Member

fixed by #874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix must have
Projects
None yet
Development

No branches or pull requests

2 participants