Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import external formula for coefficient functions #53

Closed
alecandido opened this issue May 28, 2020 · 2 comments
Closed

Import external formula for coefficient functions #53

alecandido opened this issue May 28, 2020 · 2 comments
Labels
physics physics features refactor Refactor code

Comments

@alecandido
Copy link
Member

In order to import external formulas, like ones in vogt, that are usually encoded in small fortran functions, it would be a good a idea to download and collect them in a single 'external' folder, and write a Makefile to compile this folder in a corresponding one importable from python.

Than Makefile should provide an install command to install the new python importable coefficient functions' expressions in yadism package.

In the package everything should be organized as it is, but the ESF implementations (F2light, F2charm, ...) instead of defining themselves the coefficient functions should only import them.

@alecandido alecandido added physics physics features refactor Refactor code labels May 28, 2020
@alecandido
Copy link
Member Author

We have a final answer to this issue:
everything will be translated to python

If anyone is interested in "how to port fortran code to python" we provided a definitive answer also for this question:
by hand
(the rationale is that fortran code involved is almost python code, in the sense that there is only math involved, so copy and paste it's really the least expensive way of porting)

The full structure for hosting coefficient functions has been set in #72.

@felixhekhorn
Copy link
Contributor

translation done in #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics physics features refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants