Make chgres_cube.fd read operational GFS FV3 IC to generate FV3 WAM IC #165
Comments
HenryJuang-NOAA
changed the title
|
With the help from Kate Friedman, I can get GFS initial condition (IC) of FV3GFS v15 or v16. With the help from George Gayno, I had all the required configure nml files for GSM, v15, and v16 ICs to run chgres_cube. With the works have been tested by me in issues #163 and #164, we can run chgres_cube with different ICs to generate WAM IC. |
…ity#164, and ufs-community#165. It uses namelist parameters wam_cold_start and wam_start_date to control the chgres_cube to run WAM IC or not. One subroutine VINTG_WAM is coded to generate o, o2, and temperature over thermosphere by a group of subroutines in a file called wam_climo_data.f90 And it can read GSM, FV3v15 and v16 ICs to generate WAM IC.
…into udhmhj.01 conflict fixed. relate to issue ufs-community#165 before reg tests merging with develop.
|
We also need a test. |
|
You mean IC data to test, right? I am still checking the code, I will
provide later.
…On Fri, Feb 5, 2021 at 10:16 AM Edward Hartnett ***@***.***> wrote:
We also need a test.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWWEKGNZTWI6IZMGHKJ3LS5QDS5ANCNFSM4SE7YDXA>
.
|
For ufs-community#163, 164 and ufs-community#165 with up to dated from upstream develop.
|
The issues 0f #163 and #164 and this issue #165 have been resolved with newly created WAM IC tested successfully in FV3 WAM. To create WAM IC, use my branch udhmhj.02, the test location is ud/chgres_wam. There are three nml files point to gsm, v15, and v16 IC datasets and the run.sh can be submitted to get WAM IC from these nml files, one by one as needed. |
|
This issue has been finished and ready for pull request. |
|
OK I don't think we can expect unit testing from this code. We need to provide better examples of what unit testing is first. So if we have adequate regression testing, we can go with that. |
|
I didn't build a regression test for it, but I have GSM, V15, and V16 IC and workflow to run chgres)cube with WAM option to create WAM IC, with G. Gayno's help. Ed, do you want WAM regression build? |
|
I don't understand much of what you are asking. You don't have a regression test or unit testing? We certainly need one or the other. Can you explain to me how this code should be tested, if it has to change? |
|
This issue is to create a WAM IC(initial condition) from operational GS or FV3 GFS V15, or V16 IC. WAM is a whole atmospheric model based on FV3 GFS with model top up into thermosphere (model top pressure is about 10^-7 pascal). To have the WAM IC, we need temperature profile and O, O2, O3, and remain N2 profiles from current GFS model top to WAM model top. There is a new file contains all necessary data and routines to create the vertical temperature and compositions profiles in function of latitudes and height. |
|
Then yes, we need the regression test. |
|
Do we have any document which describes how to create baseline and do reg test? |
Yes, go ahead and get it working on Hera for now. |
|
I will create baseline in my directory and ask to save into HOMEreg later. |
fix conflict. Issue ufs-community#165
merge with current develop and fix coflict. issue ufs-community#165
|
I believe I have done all places to document. Really don't know how to debug it to finish.... help!! |
@HenryJuang-NOAA Please merge the latest updates from 'develop'. Then I can look for doxygen warnings. |
merged with updated develop. issue ufs-community#165
|
updated develop with upstream, and merged to udhmhj.02, pushed.
…On Wed, Mar 24, 2021 at 4:20 PM GeorgeGayno-NOAA ***@***.***> wrote:
I believe I have done all places to document. Really don't know how to
debug it to finish.... help!!
@HenryJuang-NOAA <https://github.com/HenryJuang-NOAA> Please merge the
latest updates from 'develop'. Then I can look for doxygen warnings.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWWEMJTS5NERBIMWNQ7BTTFJCQPANCNFSM4SE7YDXA>
.
|
|
George, |
The ./ud directory must be deleted before merging. You can either keep those files locally or add them to another branch in your fork that won't be merged. A regression test should be included in this PR. |
|
George, |
Initially, I would not create a test for every possible input data type. You can pick the input data you think most folks will use. Another consideration: the v16 data has a much higher model top than v15. Which is the better test of your algorithm? |
|
Agree. Which input in your input_data directory is v16?
…On Fri, Mar 26, 2021 at 1:52 PM GeorgeGayno-NOAA ***@***.***> wrote:
George,
I am doing to create reg_test for wam ic. What input data do you think I
should use? or I have to have all different ic for wam ic? I need cold
start wam ic from any archived data, say GFS GSM or GFS FV3, maybe for
future cases, we should use operational GFS FV3 restart files or analyzed
data ic? need your suggestion...
Initially, I would not create a test for every possible input data type.
You can pick the input data you think most folks will use. Another
consideration: the v16 data has a much higher model top than v15. Which is
the better test of your algorithm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWWEOK36RXMBLBLIQ3IG3TFTCW3ANCNFSM4SE7YDXA>
.
|
/scratch1/NCEPDEV/da/George.Gayno/noscrub/reg_tests/chgres_cube/input_data/fv3.netcdf |
|
Okay! So I can start from c96.fv3.netcdf.sh to create c96.fv3.netcdf2wam.sh.
Is it named okay? Well, let me do it first, we can change the file name
later if we want. Thanks.
…On Fri, Mar 26, 2021 at 2:23 PM GeorgeGayno-NOAA ***@***.***> wrote:
Agree. Which input in your input_data directory is v16?
/scratch1/NCEPDEV/da/George.Gayno/noscrub/reg_tests/chgres_cube/input_data/fv3.netcdf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWWEMM26QX6EWSLJU2MZDTFTGJJANCNFSM4SE7YDXA>
.
|
Need create baseline for c96.fv3.netcdf2wam just added reg_test/
|
George, |
related to issue ufs-community#165
|
George
I need your help to copy baseline of WAM IC regtest.
Thanks,
Henry
…On Fri, Mar 26, 2021 at 2:23 PM GeorgeGayno-NOAA ***@***.***> wrote:
Agree. Which input in your input_data directory is v16?
/scratch1/NCEPDEV/da/George.Gayno/noscrub/reg_tests/chgres_cube/input_data/fv3.netcdf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWWEMM26QX6EWSLJU2MZDTFTGJJANCNFSM4SE7YDXA>
.
|
update from upstream/develop to develop to udhmhj.02 for issue ufs-community#165.
Add some print to program_setup.F90. Fixes ufs-community#165
related to issue ufs-community#165 and PR ufs-community#388.
Adjust consistency test to only process the atmosphere. Fixes ufs-community#165
|
Thanks.
…On Mon, May 24, 2021 at 10:09 AM GeorgeGayno-NOAA ***@***.***> wrote:
Closed #165 <#165> via d049b28
<d049b28>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWWELG4C4OUE4U45PSJTDTPJMYTANCNFSM4SE7YDXA>
.
|
We have done the checking on reading GFS GSM IC with tracers of spfh, clwmr, o3mr to WAM IC with the same kinds of tracers. We have to make chgres_cube can read current GFS IC (FV3 IC) and possible to add more tracers, such as o and o2 for WAM IC.
The text was updated successfully, but these errors were encountered: