Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with element-wise comparisons that have NDV and a value pairing. #25

Closed
fernando-aristizabal opened this issue Feb 24, 2023 · 1 comment · Fixed by #30
Closed
Assignees
Labels
enhancement New feature or request

Comments

@fernando-aristizabal
Copy link
Member

fernando-aristizabal commented Feb 24, 2023

Dealing with element-wise comparisons that have NDV and a value pairing.

Current behavior

  • Element-wise pairing with value-value pairs yields a value.
  • Element-wise pairing with NDV in either candidate or benchmark yields NDV.
  • This functionality is done in gval.compare.compute_agreement_xarray() along with the comparison_function arg.

Expected behavior

  • User's may want to denote situations where candidate or benchmark has a value and the other is NDV.
  • This represents a "value mis-alignment" that user's may want represented in the agreement map.
@fernando-aristizabal
Copy link
Member Author

Current behavior in pairing_dict branch allows for "value misalignment" with the pairing_dict comparison function argument. No support is currently being given for "value misalignment" with the other comparison functions including cantor and szudzik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant