Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwm_client_new does not have a __version__ attribute #144

Closed
jarq6c opened this issue Oct 27, 2021 · 2 comments · Fixed by #149
Closed

nwm_client_new does not have a __version__ attribute #144

jarq6c opened this issue Oct 27, 2021 · 2 comments · Fixed by #149
Assignees
@jarq6c
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jarq6c
Copy link
Collaborator

jarq6c commented Oct 27, 2021

Trying to limit the scope of the recent massive PR. I will address this later.
@jarq6c jarq6c added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 27, 2021
@jarq6c jarq6c self-assigned this Oct 27, 2021
@aaraney
Copy link
Member

aaraney commented Oct 28, 2021

related to #142. once #142 is merged, I am can open a PR to address this if you'd like?

@jarq6c
Copy link
Collaborator Author

jarq6c commented Oct 28, 2021

No preference on who does it. I'm good to merge that PR, just wanted to talk about the hydrotools fake package.

@aaraney aaraney mentioned this issue Oct 29, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarq6c jarq6c

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move nwm_client_new version inside package source aaraney/hydrotools
2 participants
@jarq6c @aaraney