Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stateCd does not work with nwis_client #90

Closed
jarq6c opened this issue Jun 14, 2021 · 2 comments · Fixed by #93
Closed

stateCd does not work with nwis_client #90

jarq6c opened this issue Jun 14, 2021 · 2 comments · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@jarq6c
Copy link
Collaborator

jarq6c commented Jun 14, 2021

I had not realized certain options were non-functional with the current version of nwis_client. These options appear to work with the version on the restclient_transition branch. So, I would say that makes getting this branch merged into main a high priority.

@aaraney
Copy link
Member

aaraney commented Jun 15, 2021

Yeah good catch, I was not aware of that either. That sounds like something a pytest --run-slow should have caught. I need to create a new gh-action that runs our slow tests every Sunday if something new has been added since the last time the action ran.

@aaraney
Copy link
Member

aaraney commented Jun 15, 2021

Something similar to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants