Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of overloaded and/or inverted objective functions for algorithms requiring minimizing vs maximizing of cost/score #55

Open
hellkite500 opened this issue Jul 18, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right

Comments

@hellkite500
Copy link
Member

Per @mattw-nws comment on #41:

Strongly believe we shouldn't change this/use the same name... can we instead add
"one_minus_kling_gupta": objectives.kge,
... and really, also change kge to be named one_minus_kge?
Alternatively, we could add code that detected a non-zero target whenever PSO was used, and automatically optimize for target - f(x) instead, issue a NOTICE, and then re-invert the value when we're outputting the objective scores to the user? This last part > would be important if we do "magic" like this.

We need to take some steps to address these issues.

@hellkite500 hellkite500 added documentation Improvements or additions to documentation invalid This doesn't seem right labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant