Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using default mapping in config/cfe.py causes PET+CFE calibration to fail #91

Open
Ben-Choat opened this issue Jan 8, 2024 · 0 comments

Comments

@Ben-Choat
Copy link
Contributor

Ben-Choat commented Jan 8, 2024

Short description explaining the high-level reason for the new issue.

Current behavior

Using default mapping in config/cfe.py causes PET+CFE calibration to fail, but removing causes PR checks for build (3.7) and build (3.8) to fail.

I submitted a PR commenting out the default mapping, Update cfe.py - remove QINSUR as default variable name mapping #90, but configuration checks fail with below error.
It appears the tests expect the default mapping to be present.:

=========================== short test summary info ============================
FAILED python/ngen_conf/tests/test_cfe.py::test_name_map_default - KeyError: 'atmosphere_water__liquid_equivalent_precipitation_rate'
FAILED python/ngen_conf/tests/test_multi.py::test_name_map - KeyError: 'atmosphere_water__liquid_equivalent_precipitation_rate'
======================== 2 failed, 101 passed in 0.46s =========================
Error: Process completed with exit code 1.

Expected behavior

Calibrating with PET+CFE works.

Steps to replicate behavior (include URLs)

  1. Run calibration with PET+CFE. (Note SLOTH is required with CFE).

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant