Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for consistency in land cover and soil #97

Open
SnowHydrology opened this issue Feb 7, 2024 · 0 comments · Fixed by #100
Open

Check for consistency in land cover and soil #97

SnowHydrology opened this issue Feb 7, 2024 · 0 comments · Fixed by #100
Assignees

Comments

@SnowHydrology
Copy link
Contributor

Current behavior

You can run Noah-OM with nonsensical, inconsistent soil and land cover values. As we saw in NOAA-OWP/DMOD#472 (comment), this can lead to model errors.

Expected behavior

Noah-OM should not initialize if inconsistent values of land cover and soil are provided.

Suggested changes

I've flagged an issue on the hydrofabric repo, but we should also implement model-level sanity checks. These will stop initialization and throw an error message if land cover and soil are inconsistent.

Specifically, Noah-OM should check the values of isltyp and vegtyp for consistency. I provide example category lumpings in the linked hydrofabric issue above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants