Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent sigma to child sigma #140

Open
micdom opened this issue Jun 22, 2023 · 1 comment
Open

parent sigma to child sigma #140

micdom opened this issue Jun 22, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Projects

Comments

@micdom
Copy link
Contributor

micdom commented Jun 22, 2023

pyBDY does not work with ln_sco = .true. ! s- or hybrid z-s-coordinate.
We have to consider keeping this option in some form if we are going to include an option for parent sigma to child sigma.

@micdom micdom added the enhancement New feature or request label Jun 22, 2023
@jdha jdha added this to To do in PyBDY dev via automation Apr 15, 2024
@jdha
Copy link
Collaborator

jdha commented Apr 15, 2024

Initial thoughts:

Create a generic Depth Class to handle source and destination 3D vertical coordinates.

unit tests to include:

source data with:
zt, zw, zu, zv, e3t, e3w, e3u, e3v
this is reduced incrementally to input with only:
zt (making some crude assumptions to derive other vertical variables)

[both in 1D and 3D formats]

In all cases a vertical weighting is generated to allow horizontal interpolation on a common depth level [in the simplest case of ZCO this will default to 1 on the common depth level].

ln_sco flag to be removed as this was used in NEMO <=3.6 when we made use of hc and sigma coefs

The destination 3D vertical coordinate Class will assume NEMO >=4.0 and access to a current style domain_cfg or mesh_zgr file for simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
PyBDY dev
  
To do
Development

No branches or pull requests

4 participants