Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to keep the vertical grid of the source data #158

Open
rdPatmore opened this issue Apr 10, 2024 · 3 comments
Open

Add option to keep the vertical grid of the source data #158

rdPatmore opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@rdPatmore
Copy link
Contributor

There is currently no option to retain the vertical grid of the original source data. It would be usefull to have this as a namelist option.

@jdha
Copy link
Collaborator

jdha commented Apr 10, 2024

Hi Ryan - I've been using this option for many years - it was introduced when I wrote the interpolation-on-the-fly in the core NEMO code ... so there is an option somewhere - but it maybe a little opaque! I've avoided pyBDY for too long now. I'll clear the schedule tomorrow and focus on getting pyBDY tasks in order. Apologies.

@jdha jdha self-assigned this Apr 10, 2024
@jdha jdha added the enhancement New feature or request label Apr 10, 2024
@jdha jdha added this to To do in PyBDY dev via automation Apr 10, 2024
@rdPatmore
Copy link
Contributor Author

Hmm I couldn't see anything obvious. The only thing I found in the code is the isslab flag. If you could point me to the option, that would be great.

The motivation for using this option is that I'm finding strange results in my forcing whereby there is a jump in Temp and Salinity at the bounday (see image). I have AMM15's sigma grid as the destination. I am using pyBDY's zps option but feeding it gdept_0 as the depths, so I thought that would be fine (the sco option does not work as the variables required appear to be relevant to a different version of NEMO). My solution was to avoid vertical interpolation and let NEMO do it on the fly.

Screenshot 2024-04-10 at 10 00 34

@jdha
Copy link
Collaborator

jdha commented Apr 10, 2024

Yeah - I wrote the bdy-on-the-fly in NEMO 6-7 years ago and haven't used vert interp in pyBDY since then ... will look tomorrow ... in the meantime I guess you could feed the sn_src_zgr to sn_dst_zgr .... not too sure whether the code will broadcast 1d->3d ok in this instance though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
PyBDY dev
  
To do
Development

No branches or pull requests

2 participants