Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoM 1.7.1 (826) - broken import on Android #1045

Closed
redwolf2 opened this issue Feb 2, 2019 · 21 comments
Closed

MoM 1.7.1 (826) - broken import on Android #1045

redwolf2 opened this issue Feb 2, 2019 · 21 comments
Labels
Milestone

Comments

@redwolf2
Copy link
Collaborator

redwolf2 commented Feb 2, 2019

Description of Problem or Question

The latest update to version 1.7.1 (826) seem to have a new sprite Atlas. Windows does not seem to be affected, there was an update for it yesterday, I tested.

Obb file affected: main.821.com.fantasyflightgames.mom.obb

See also: #964

1.7.0

image

1.7.1
1 7 1

Valkyrie Version

2.5.1 (Android)

@redwolf2 redwolf2 added the bug label Feb 2, 2019
@scrubbless
Copy link
Collaborator

It's like they do it on purpose

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 2, 2019

We need to find a long term solution for this :(
There must be a way to get the index of this atlas.

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 3, 2019

The SpriteAtlas is in sharedassets3.assets.
Maybe we could tune the importer to export every single sprite https://docs.unity3d.com/ScriptReference/U2D.SpriteAtlas.GetSprites.html

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 3, 2019

My motivation to work on this is close to zero.

I really want to finish what I have started with the Scenario explorer.
I'll look at this after I've released the next test version.

If someone want to fix this in the meantime here is an example of what needs to be done.
No coding required.

Example :
35842cf

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 3, 2019

@redwolf2, yes your proposal would probably make the change a bit less tedious.
But I'm not sure we can even use that function, as we may need an index of the Atlas.
Or do you think it's in the file itself ?

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 3, 2019

Release, when done is ok for me.

I found no meta data, that contains the indices. Maybe this is auto generated code, I am not sure.

Last option is recreating the tokens without images, just names.

@scrubbless
Copy link
Collaborator

@BenRQ do you have a latest release we can test?

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 3, 2019

Release, when done is ok for me.

I found no meta data, that contains the indices. Maybe this is auto generated code, I am not sure.

Last option is recreating the tokens without images, just names.

token

token2

@scrubbless
Copy link
Collaborator

But it would still jumble the other tokens, like search, walls etc

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 3, 2019

Those do not seem to be affected ATM, but can also be recreated.

@BenRQ Don't focus on this issue, I will try to come up with a custom tilemap that is compatible to the one used in 2.1.5

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 3, 2019

Last option is recreating the tokens without images, just names.

From what I've read on sprite atlas, I'm pretty sure it's Unity who is generating this from sprites.

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 3, 2019

@BenRQ do you have a latest release we can test?

I will have ... "soon"

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 3, 2019

Alright, I got the Character Token, but I need all names of those guys. I will do the default explore, search, etc. token next.

spriteatlastexture-atlas_features_core group 0 -2048x1024-fmt12_original

spriteatlastexture-atlas_features_core group 0 -2048x1024-fmt12

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 3, 2019

You don't have this yet ? :)

https://cdn.discordapp.com/attachments/517395720446410782/530821468519530506/49438987_2415020575239019_4873057906787876864_n.png

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 3, 2019

spriteatlastexture-atlas_features_core group 0 -2048x1024-fmt12

Got the tokens now, will go for investigators and names.

Update, got investigators, will go for names:

spriteatlastexture-atlas_features_core group 0 -2048x1024-fmt12

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 4, 2019

spriteatlastexture-atlas_features_core group 0 -2048x1024-fmt12

All currently supported investigators by 2.1.5 mapped. Should be release ready.

Font used: oldnewspapertypes.ttf

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 4, 2019

The above should work. I will test to integrate it. On the next iteration, I want simple icons for male/female, colored token. After that I might add own vectors (old woman, child, boy, nurse, etc.) for the different colored token.

Update:

grafik

grafik

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 5, 2019

I created a pull request: #1049

@BenRQ
Copy link
Collaborator

BenRQ commented Feb 6, 2019

I got this log while accessing the editor (after the merge) :

Token SylviaMarshdid not have an image. Skipping

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 6, 2019

Fixed it. I forgot to remove the {import} dir replacement there.
#1052

@redwolf2
Copy link
Collaborator Author

redwolf2 commented Feb 9, 2019

Merged

@redwolf2 redwolf2 closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants