New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021Q2 Roadmap #143
Comments
Update from Texas: sorry I haven’t been around much lately. Between business travel and bathroom remodeling I haven’t had any extra time to play with my automations. My systems are still working great. I have one light that turns “on, 0% bright” sometimes but generally the plugin is working. I’m running 4 pi’s and haven’t made any big updates for months. I promised esp-32 camera testing a while ago. I bought 4 or 5 of them and the build quality was extremely disappointing (2 were broken before I opened them). I lost interest in those and am now saving up for Unifi cameras. I’m looking forward to any updates coming! I’d like to encourage bug fixes (deploy bug!) and characteristics (persistence?) updates - those will likely be most beneficial to the community. If you want more of my opinion - you know where to find me 😉 |
Thanks for sharing @crxporter I have updated roadmap with my recent ideas how to fix current situation. |
Roadmap looks good, just update to 0.7.0 i did have to rework most of my flows due to no longer getting a msg.hap payload, but it actually is cleaner now since message are no longer passed through <3 Hope your break was well @Shaquu. Also what is the 2nd output for now? Neither of them are labled but there seems to be nothing on the 2nd one for now. |
@Shaquu Why there is no msg.hap message? This means that I also have to rewrite some flows :) |
Wait what? :) abort! |
That's what I wanted to say :) I couldn't recall this, that we wanted to delete this. |
send a change to a service, it updates in HK, but no output of the new value (which I was filtering out based on the msg.hap being present or not depending on if it was passthrough or a change from homekit.) |
Is there an output if you change state from HomeKit? |
Yes, you still get output if you do a change via homekit. input state change -> homekit service = no output It took me about 10min to fix my states, and it is a lot simpler now :p as the only output you get are changes originating in homekit. |
Maybe there is a change in node-red 1.x.y? Can you help me figure it out? |
I get this error: "TypeError: Cannot read property 'context' of undefined". And really, there is not seem to be a hap.context. Whole msg object: object And really, a second output appered. |
I'm about to go to bed, but I can get you a copy of the current output on change originating in hone.app {
"payload": {
"On": false
},
"name": "Desk Lamp",
"topic": "zigbee2mqtt/bedroom/desk_lamp",
"_msgid": "e6bd2b09.cb8468"
} |
Yeah, but I am not getting any output on that. |
I think this is also not intended to appear. It's just a bug, maybe related to the previous... |
Okay. Second output is for camera snapshots! |
Really... I forgot about that :) |
Can we somehow label them? Well we can in node-red, but like set a default one I mean. |
Also my Node-RED version is outdated... I will try to update it. |
Added labels for outputs in 0.7.1 |
Also home.app looks more responsive too, so maybe it is a HAP-nodejs change. |
So what exactly should I add to notes? |
I think he reflected to the HAP-nodejs changelog. Maybe something changed there that's why we don't get the context of the msg. If this is the case and intended, this is a breaking change. Every msg.hap.context == undefined check needs to be deleted... |
Exactly this, I just removed the check as there is no longer a need to discard the pass through messages of old. |
Should we delete these checks @Shaquu ? This is how it will work from now on? |
Sorry, I need time to investigate :) I didn't have those checks so I have no idea. |
Okay so you mean hap.context which should be forwarded from input to the output, correct? |
msg.hap.context was added to the output message by the HomeKit node. It was undefined if the message was not originated from the HomeKit node itself, but was only a passthrough message. That was the only way you could "close" the loop. Anyway it really seems better, faster as @sjorge said. Also if I'm accessing it through a hub, so I'm not in local connection, now it works instantly, before I had to open and close a few times to connect properly. |
msg.hap.context issue is being resolved on dev branch. #157 |
Hold up - this is a HUGE breaking change for me. I haven't updated anything for a while. Are passthrough messages still there? I depend on the pass through messages. I will have to re-think my whole setup if these are gone. Just saw #157 and it looks like things are back to normal. I just had a mini panic attack. Everyone please carry on. |
Yes sorry, we luck test power and tests are weak and people demand new releases :)
My mistake, next time I will look at other people commits more precisely.
Anyway, in 0.8.0 everything should work the old way plus option in bridge configuration to disable pass through.
…On 14 Oct 2019, 19:06 +0200, crxporter ***@***.***>, wrote:
> Every msg.hap.context == undefined check needs to be deleted...
Hold up - this is a HUGE breaking change for me. I haven't updated anything for a while. Are passthrough messages still there? I depend on the pass through messages. I will have to re-think my whole setup if these are gone.
Just saw #157 and it looks like things are back to normal.
I just had a mini panic attack. Everyone please carry on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Now you can download dev version using: I will add automatic publish for dev version soon. |
@Shaquu This will become a game changer! |
Does it mean my work here is over? |
@Shaquu probably not, It's more of a the work for HAP-NodeJS got easier because there will be less guessing. |
That's huge! Yes I think it mainly applies to HAP-NodeJS, it will be easier for them to implement new device types and found out why is something not working, the painful reverse engineering can be replaced by using these I think. |
Oh now! Please remain motivated! But things may change now significantly for tow reasons
|
Yes @djiwondee you are right. I think this is the first move towards that standard (I mean that open-sourcing these things). |
I'm finally back to testing! I've loaded up the dev.4 branch this morning and I'm ready to test. I honestly don't even remember what is new and fixed at this point. What should I be focusing on? Re deploy bug? I'll spend some time going through things here if y'all can remind me what to test! |
Yes I also have that. I don't know why. Nothing changed updated (at least regarding Node-RED and HomeKit). |
Yeah I'm still running my house mostly with 0.6.2 - works so well I see no reason to mess with it until I'm doing "big upgrades" hopefully later this year (I have some big dreams). I'm doing testing on a pi at work with a separate icloud account from my personal account. I have an ipod touch and a mac pro on the account - I probably need to round up an ipad or apple tv so I have a hub to test...
Which version is this happening on? My 0.6.2 "big bridge" has 36 accessories all working great, uptime is 45 days right now that I haven't redeployed, restarted, or anything. |
@crxporter Here is the changelog: There are many improvements. Please keep in mind that previous (0.8) version was based on broken hap-nodejs (0.5) and it’s why there were so many problems. Regarding important stuff. You will have to re add all accessories to home app since Mac for them is generated in different way now. Next I would recommend not using production environment if you have a stable one already. Make a backup. |
@crxporter I have around 50 accessories on 2 bridges (around 25-25 on each one..). |
Regarding current dev branch tests status if there is no need to create new Issue please comment here #163 |
I am closing this one. We have plenty ideas on development and also we are open for everyone's comments in Discussions or on Discord. Current roadmap will be visible in Project tab on our repository. |
Roadmap for upcoming months:
reloadable HapNodeJS as child processFurthermore, as there is a new HAP documentation accessible publicly there will be a lot of effort to keep HapNodeJS updated and compliant.
All above is subject to change.
Sent with GitHawk
The text was updated successfully, but these errors were encountered: