CheckConvexity throws Surface is Non-Convex warnings regardless of ShadowCalculation settings

[mjwitte]

Issue overview

User file with PixelCounting is throwing warnings like this:

   ** Warning ** CheckConvexity: Zone="CEILING VOID ZONE A.A.4.1", Surface="CEILING VOID A.A.4.1:INTERZONE A.A.5.1:3" is non-convex.
   **   ~~~   ** ...vertex 3 to vertex 4 to vertex 5
   **   ~~~   ** ...vertex 3=[45.72,36.58,15.75]
   **   ~~~   ** ...vertex 4=[36.58,36.58,15.75]
   **   ~~~   ** ...vertex 5=[36.58,45.72,15.75]

1. The documentation mentions that zone convexity doesn't matter with PixelCounting but it does not mention surface convexity. @nealkruis says pixel counting should not care about convexity. (also see Documentation 2023-2024 #9972 (comment)).
2. The documentation for Polygon Clipping Algorithm implies that these warnings should only be active when using ConvexWeilerAtherton.
3. Is there some other reason (e.g. daylighting, diffuse shading, or other geometric calculations) that would warrant a non-convex surface warning here?

Details

Some additional details for this issue (if relevant):

• Version of EnergyPlus 23.2
• Helpdesk ticket 16495

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added EnergyPlusDevSupport\DefectFiles
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)